Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster hp bar fix #2008

Closed
wants to merge 1 commit into from
Closed

Monster hp bar fix #2008

wants to merge 1 commit into from

Conversation

Jedzkie
Copy link
Contributor

@Jedzkie Jedzkie commented Apr 2, 2018

Pull Request Prelude

Changes Proposed

In official servers, monster hp bar is not shown when you hit MVP Monsters.

Affected Branches:
master

Issues addressed:

Known Issues and TODO List

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@AnnieRuru
Copy link
Contributor

can we do this as battle_config ?
or else members will start complaining suddenly seeing a feature they used to and suddenly it disappear

also, MD_BOSS also included mini-bosses like Angeling, Mastering, Chimera, Bloody Knight, etc...
make sure you check

@Jedzkie
Copy link
Contributor Author

Jedzkie commented Apr 3, 2018

@AnnieRuru sure. Yeah, mini boss also don't have hp bars. even emperiums and barricades

@tlacson7
Copy link

tlacson7 commented Apr 4, 2018

how about emperium?

@Jedzkie
Copy link
Contributor Author

Jedzkie commented Apr 4, 2018

@tlacson7 even emperiums doesn't have hp bar. only normal monsters.

@AnnieRuru
Copy link
Contributor

that's why I also felt like rathena did the wrong way
they use hidemobhpbar mapflag

I think the correct way is just hiding the specific ID of monsters...
can you confirm WoE guardian also has hp bar ?

@4144
Copy link
Contributor

4144 commented Apr 4, 2018

then probably add flag into mob_db to show/hide hp bar?

@Asheraf
Copy link
Contributor

Asheraf commented Apr 4, 2018

actually we need to be able to set a monster class from the db as in aegis they have 4 classes CLASS_Normal, CLASS_MVP, CLASS_Boss, CLASS_Guardian the hp bar show only for CLASS_Normal also there is a script command to force showing it showmobhp.. this is to be used with other things as well such as the class icon near the name for mobs/pets....

@Jedzkie Jedzkie self-assigned this Apr 4, 2018
@Jedzkie Jedzkie added type:enhancement Issue describes an enhancement or feature that should be implemented codereview:needsedits Some edits have been requested before the pull request can be accepted status:on-hold The issue was put on hold until another issue is solved or a feature is implemented labels Apr 4, 2018
@Jedzkie Jedzkie closed this Jul 29, 2018
@Jedzkie Jedzkie deleted the MonsterHPFix branch July 29, 2018 03:12
@Samuel23 Samuel23 mentioned this pull request Jan 6, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codereview:needsedits Some edits have been requested before the pull request can be accepted status:on-hold The issue was put on hold until another issue is solved or a feature is implemented type:enhancement Issue describes an enhancement or feature that should be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants